fix(test): Flakiness in KHLL uniqueDistribution test #16237
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@HeidiHan0000 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D92242037. |
✅ Deploy Preview for meta-velox canceled.
|
meta-cla
bot
added
the
CLA Signed
…or#16237) Summary: There was some flakiness in the uniqueness distribution test when the expected was 0, because it would allow 0 tolerance. Fix: use a larger tolerance (2/size which allows for error up to 2 values in that bucket) while comparing buckets with too few expected values Differential Revision: D92242037
HeidiHan0000
force-pushed
the
export-D92242037
branch
from
6b1daf9 to
dec54ca
Compare
kgpai
approved these changes
Feb 4, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16110
Summary: There was some flakiness in the uniqueness distribution test when the expected was 0, because it would allow 0 tolerance. Fix: use a larger tolerance (2/size which allows for error up to 2 values in that bucket) while comparing buckets with too few expected values
Differential Revision: D92242037